LADX: text shuffle exclusions #3919
Conversation
Exclude owl statues, library books, goal sign, signpost maze, and various rupee prices from text shuffle
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
|
Again, I feel like this would make sense as a user-facing option. It could by default do this, but I think it would make sense to at least have the option be available |
I'm a big believer in YAML options but this is like asking to have a YAML option to keep erronous implementations in. zig wanted to exclude this when he initially implemented text shuffle but simply forgot and since then just didn't have time. This is preserving nobody's idea. Having these options in text shuffle lessens the experience for all users as, for example, the Egg Path Textbox WILL be on another object but WILL NOT display the correct text (which path it is) which leads to users being confused and frustrated because they believe the shuffled textbox is correct. They also shuffle the path when talking to the book for the first time WITHOUT being able to EVER find out the right path without having the meta knowledge of knowing all four paths. @threeandthreee Just to make sure: Will this also prevent those text boxes to be in the pool? So will the Egg path be anywhere else if the original egg path is not text shuffled? |
Each path text is excluded, yeah. Should only show up in the book and should be the correct one as its completely left alone, though I didn't directly test that. |
Then the full extent of why changes are being made should be included in the PR description. None of what you just said was in any way apparent |
|
There was a problem hiding this comment.
The feature is completely unusable in my opinion without this addition. There's randomizing text, and there's unexpected and usual gameplay in a randomizer, and sometimes game can't completely support providing all of the information needed for Archipelago and you gotta keep an eye on your text client. That's all fine.
Without this change, though, this 'feature' simply straight up lies to the player and obfuscates critical information such as "how do I finish the game." The changes proposed complete development of a feature that was only ever partially implemented.
There was a problem hiding this comment.
This PR was tested as part of a Beta apworld that was used in three dedicated Test Asyncs, as well as dozen of normal Syncs. I have also personally run 200 test generations which succeeded.
The new feature has worked as expected and other stuff does not seem impacted.
I explained why we need this PR especially in a previous comment: #3919 (comment)
What is this fixing or adding?
Creates a list of exclusions for text shuffle.
zig wanted to exclude this when he initially implemented text shuffle but simply forgot and since then just didn't have time. This is preserving nobody's idea.
Having these options in text shuffle lessens the experience for all users as, for example, the Egg Path Textbox WILL be on another object but WILL NOT display the correct text (which path it is) which leads to users being confused and frustrated because they believe the shuffled textbox is correct. They also shuffle the path when talking to the book for the first time WITHOUT being able to EVER find out the right path without having the meta knowledge of knowing all four paths.
Excludes:
How was this tested?
Generated solo seeds, verified intended text was unshuffled.